This repository was archived by the owner on Nov 18, 2021. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 18, 2021. It is now read-only.
Allow commenting on collapsed lines in PR #1655
Description
In a PR it seems you can only comment on the lines that are "close" to the changed lines. This is not always sufficient, since comments can be used to point out lines that will have to be changed in order to correct an issue.
For example, if in a PR you open a collapsed section of code, it seems impossible to leave a comment on any of the collapsed lines (happy to be proven wrong on this).
Reacted by Aleksander Wasaznik, Kevin, jaweesner, David Tucker, Guybrush, Jimmy Nicolacopoulos, Guilliam Xavier, Kostas Stathakos, Ara Ayvazyan, Jez Swanson and 270 more
Reacted by Chris Elliott, Robert Gilmore, Tom Keddie, Chaitanya Chinni, Alice Scholze, Alex Adams, Matthew Vernacchia, Marx, Gavin Kliger, Mario Lenci and 21 more
Reacted by Garrett Spong, Chaitanya Chinni, Alice Scholze, Alex Adams, Marx, Gavin Kliger, Mario Lenci, Albin Törnqvist, Vladimir, Scott Parish and 14 more
Reacted by Artium Nihamkin, Marcin Wanago, Husam Eldeen Elsheikh, Victor Piolin, Kanika Rana, Evandro Viva and amonsosanz
Activity
frank-weindel commentedon Sep 17, 2019
This is a duplicate of #284
kanelbulle commentedon Sep 19, 2019
Actually, no, this issue is about commenting on PRs. #284 is about allow commenting on non-PR code.
alkhimey commentedon Jul 1, 2020
Any chance this issue will be addressed? I find myself commenting on arbitrary lines with notes like
this comment actually refers to line #1337:.vimalk78 commentedon Jul 31, 2020
same here. allow comments on lines far from changed lines
molshansky-zipwhip commentedon Aug 22, 2020
This feature would be amazingly helpful. Sometimes we are reviewing code that is a work in progress and realize that something is amiss from a previous commit and want to recommend a change going forward.
For example, I am reviewing someone's PR and see that a dependency needs to be bumped. If I could add an in-line comment requesting a change, it'd be far more efficient than making the change myself in a subsequent PR.
gurayAlsac commentedon Oct 14, 2020
+1 Sometimes a reviewer needs to point out a section that needs changing but hasn't been addressed in the PR.
grabear commentedon Oct 20, 2020
+1
agolynski commentedon Oct 21, 2020
+1
brendadeely commentedon Oct 21, 2020
Agreed with all of the above. Plus, if a commit isn't quite right, a commenter may want to suggest changes in a comment to lines that fall outside of the original commit. I personally have run into this a good dozen times at least in the last month or so.
ledmonster commentedon Nov 10, 2020
I really want this feature. I can't understand why GitHub leaves this issue as it is. This is a fundamental feature for developers.
irwineffect commentedon Nov 10, 2020
I suspect the current behavior was designed to help limit the scope of changes requested during a PR, but as others have mentioned, sometimes we really need to point out and add comments to other areas of the code that are directly related to the changes but aren't close to the changed lines.
molshansky-zipwhip commentedon Nov 18, 2020
FWIW - If this functionality is added, there's no reason it can't be toggleable so folks that want/need it can turn it on (it could be off by default).
felixpelletier commentedon Dec 10, 2020
My team does that extensively with another PR system. It's really a must have!
18 remaining items
Lafaa commentedon Apr 28, 2021
+1
Hasenherz commentedon Apr 30, 2021
+1
yelena-premise commentedon Apr 30, 2021
+1
jtramm commentedon May 4, 2021
I agree -- this is a badly needed feature. Critical to have this ability when reviewing refactored code and you need to point out lines that were missed.
VitaliiIsaenko commentedon May 11, 2021
Another use case is (design) refactoring that could lead to introducing a new class but some code that should have been moved to this class wasn't touched. I'd love to point that piece of code and comment on it about the need to move it to the newly created class.
ryomtoob commentedon May 18, 2021
+1
NathanFoley commentedon May 21, 2021
+1
nilesta commentedon Jun 1, 2021
+1
nlakritz commentedon Jun 1, 2021
+1
Levi-Lesches commentedon Jun 1, 2021
Can people stop leaving "+1" or "Me too" comments? Leave a 👍 on the issue and press "Subscribe" if you want notifications; commenting only notifies everyone watching this issue/repository. Also, GitHub does not monitor this repo so triggering notifications won't get their attention.
ddellsperger commentedon Jul 7, 2021
It looks like @dotproto has suggested this on the new GitHub discussions here. It would probably be worth subscribing there as well.
davidvincze commentedon Jul 13, 2021
+1
jc-hdez commentedon Jul 15, 2021
+1
dotproto commentedon Jul 16, 2021
To support this idea, please visit upvote (not just +1) this feature request on GitHub's feedback discussions page. A lot of people have used emoji reactions, but discussions use a separate vote system to rank requests.
Upvote button on the discussion detail view
Upvote button on the the index page
Continuing to +1 here will be much less effective than engaging directly with the GitHub team.