This repository was archived by the owner on Nov 18, 2021. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 18, 2021. It is now read-only.
Convert existing PR into drafts #1547
Description
The new Draft PR feature (#416) is a great concept, but it is very difficult make use of without being able to change the status of existing PRs. It was mentioned in that issue that conversion was needed, but since the issue is closed (with the main feature implemented) I guess it's time for an issue specifically to track this addition.
PR owners and project maintainers should be able to change the status on existing PRs to mark them as drafts.
According to both the previous PR and this Twitter thread, this request has come to the attention of at least one product manager and Github.
Activity
clarkbw commentedon Apr 23, 2019
Working on it
alerque commentedon Apr 29, 2019
@TPS This and #1551 are really not even related to all the other issues that have the
saved / drafttag, I would suggests that is a miss categorization. Drafts of comments and other messages are a completely different animal (and only visible to end users) from the draft status on PRs.TPS commentedon May 5, 2019
OT: We collaborators are having a dialogue re: best use of labels, but my rule-of-thumb is try to use label combinations that best express what the issue's about, so saved / draftpull-requests makes sense, IMHO.
xeruf commentedon Aug 12, 2019
any progress on this? I have quite a few WIP PRs in my repos and it would be great if I could just switch them to be Drafts!
wcox13 commentedon Jan 7, 2020
I am also curious whether this is still in progress. It would definitely be useful.
TomasVotruba commentedon Jan 11, 2020
I accidently created PR and wanted to go draft. Now I get lot of unwanted feedback :/
This feature could save my time and time of willing feedbackers.
priyankapatel1289 commentedon Jan 22, 2020
@TomasVotruba You know you can still remove the reviewers? Then maybe change the title and add "Draft" to it
ruben-dm-ramos commentedon Feb 3, 2020
TomasVotruba commentedon Feb 3, 2020
@priyankapatel1289 I can, but that won't stop feedback from people, that I don't want now
Sajjon commentedon Feb 4, 2020
radrow commentedon Feb 7, 2020
Labels and adding "[draft]" to PR title won't block merging, which is imo the coolest feature of drafts. I don't think this issue is very hard to solve...
mrgilman commentedon Apr 8, 2020
Hi! We just shipped this feature today. Here's the changelog entry: https://github.blog/changelog/2020-04-08-convert-pull-request-to-draft
karenetheridge commentedon Apr 8, 2020
@mrgilman You are a prince among men! thank you very much.
4 remaining items
cjw296 commentedon Apr 9, 2020
@mrgilman - any idea when this is coming to GHE?
cjw296 commentedon Apr 9, 2020
TPS commentedon Apr 9, 2020
@cjw296, @mrgilman: Umm, I'm not a 🤖.…
samirmhsnv commentedon Apr 9, 2020
Wow! Nice to hear it!
mrgilman commentedon Apr 9, 2020
@cjw296 it'll either be in the upcoming release or the following one, not sure yet.
antodoms commentedon Apr 16, 2020
Yay... this is released finally!!
benwinding commentedon Apr 17, 2020
Was delighted to see this feature subtly introduced!
vvval commentedon Apr 21, 2020
This option is not presented in one of my PRs. I had to close the PR and reopen it (and choose "draft" in the dropdown section)
mcolyer commentedon Apr 21, 2020
Can you provide any more detail around this? Has it happened more than once?
timotheecour commentedon Apr 21, 2020
this feature only seems to work when there are some reviewers requesting changes (not just comments but comments marked as review comments, eg requesting changes through github UI), eg:
$works for ref|ptr|pointer for all targets (c,cpp,js,vm) + other bugfixes nim-lang/Nim#14043and since we can't request changes for our own PR's, the hack I tried (request change on my own PR) can't work either...
mcolyer commentedon Apr 22, 2020
@timotheecour thanks, we'll take a closer look and see if we can figure out what's going on.
mr-feek commentedon Apr 23, 2020
Just wanted to share that I'm loving this feature!
EmilyRosina commentedon Apr 23, 2020
Does anyone know of a github action where we can change labels when the draft status is changed?
Ideally we'd be able to:
jinmayamashita commentedon May 7, 2020
@EmilyRosina my action is still a work in progress, but I hope it helps you.
https://github.com/marketplace/actions/ready-for-review.
EmilyRosina commentedon May 7, 2020
@jinmayamashita oh wow that's awesome, thank you 🎉