You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The NewClient function currently accepts two parameters: appID and apiKey. If the user is using an API token, the appid and api token have to be passed in reverse order:
instead of calling
NewClient(appID,apitoken)
the correct way to use the library is to call
NewClient(apitoken,appID)
even if the function is declared with the following signature:
funcNewClient(appID, apiKeystring) *Client {
This is stated in the README.md, but conflicts with the current variable naming. Documentation on the NewClient function should be added or the names should be changed.
Reacted by Bjørn Hald Sørensen, Wouter, Van Driessche Vincent, harryhare, Sasha Varlamov, Connor Power, catalogplus and Vingtoft
I think I've also just stumbled on this. Seems like if we set the API version to 1.1 in the console then FindByEmail doesn't work anymore. It returns a blank email and no error.
The changelog for the API says that the find by email response type has changed so I assume this lib has to change to reflect that but then it would need to know what version of the API you are targeting.
Activity
sealcommerce commentedon Dec 13, 2018
My code is something like this:
However, it's returning a blank result like this:
I'm not sure why we cannot connect to intercom with latest api version of go, could you please take a look
jonbretman commentedon Apr 17, 2019
I think I've also just stumbled on this. Seems like if we set the API version to 1.1 in the console then
FindByEmaildoesn't work anymore. It returns a blank email and no error.The changelog for the API says that the find by email response type has changed so I assume this lib has to change to reflect that but then it would need to know what version of the API you are targeting.