Repository navigation
Fix spatial listener axes and normalize quantized orientation - #3
Open
Vlad-BloodMoon wants to merge 1 commit into
Open
Vlad-BloodMoon wants to merge 1 commit into
Vlad-BloodMoon wants to merge 1 commit into
Conversation
Use -Y for right in the Firestorm/OpenSim listener basis, retain constant-power panning, and cover orientation, elevation and moving-speaker regressions. Document coordinate sources and scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mixer treated listener-local +X as right, but Firestorm and OpenSim use +X forward, +Y left and +Z up.
This fix uses -Y for right, normalizes quantized listener quaternions and includes elevation in the direction length. Distance attenuation and call handling are unchanged.
Includes geometry and moving-speaker regression tests. All CI checks pass. The corrected build was successfully tested in-world on BloodMoon.
See docs/SPATIAL_AUDIO_FIX.md for source references, formulas, before/after examples and validation limits. This branch contains no downstream release or installer changes.