Repository navigation
fix(server): preserve secure auth and honor standalone configuration - #97
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved storage-path and backend-configuration issues block approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Updates standalone server startup to load configuration, apply CLI overrides, and enforce TCP authentication defaults.
Changes:
- Adds config, bind, data, port, and authentication CLI options.
- Applies configured binding and TCP authentication to the server.
- Adds argument-parsing and override tests.
Review findings:
- Critical (1 vote): Configured WAL and snapshot paths are ignored.
- Moderate (3 votes): Backend configuration and CLI override are unsupported.
- Nit (1 vote): CLI reference documentation omits the new security flags.
| File | Summary |
|---|---|
src/main.zig |
Loads configuration, applies overrides, configures binding and authentication, and adds tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 729f717cac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
igorls
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a08d3d5b04
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 605d7db480
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Load standalone settings from JSON and apply only explicitly supplied CLI overrides. Preserve TCP AUTH, configured verification keys, gateway authentication and replication trust checks while reconciling the original patch with current main.
Pass the complete store configuration through, including WAL size and compaction settings. Resolve relative WAL and snapshot paths under the effective data directory and retain absolute paths. If an older durable file would be skipped by honoring configured paths or data, reject startup with a migration message instead of silently reopening without it.
Accept
--backend threadpooland reject unsupported standalone backends before creating storage or starting listeners. Epoll and io_uring remain engine APIs without TCP AUTH handling. Document supported options and authentication opt-outs.Validation
zig build test: 321 tests passed on Windows and Linux after integrating fix(wasm): harden allowlist checks and validate browser builds #99; this now includes main configuration tests and the WASM checker.Compatibility
Default snapshots now live under
data. ForLegacySnapshotPathorLegacyWalPath, migrate the old file or set the corresponding store path to its absolute existing location. The checks cover custom configured filenames and changed data directories. IfLegacyWalModeis reported, recover in full mode first, save any needed snapshot, and migrate or archive the old WAL before changing the configured mode. Authentication remains enabled by default; keyless protected listeners remain locked.