Skip to content

Define abstract HTTP client tests #98

Open
Open
Define abstract HTTP client tests#98
Labels
area:testsgood first issueGood for newcomershelp wantedExtra attention is needed

Description

@pavolloffay
pavolloffay
opened on Nov 11, 2020

Define abstract HTTP client test class that will be used to test HTTP client instrumentations. As a starting point we could use okhttp tests

javaagent/instrumentation/okhttp/okhttp-3.0/src/test/java/io/opentelemetry/instrumentation/hypertrace/okhttp/v3_0/OkHttpTracingInterceptorTest.java

Line 38 in 6395bc9

public class OkHttpTracingInterceptorTest extends AbstractInstrumenterTest {

  • test JSON capture
  • test plain text capture
  • test x-www-form-urlencoded capture
  • test headers capture

Activity

  1. pavolloffay
    added
    area:tests
    good first issueGood for newcomers
    help wantedExtra attention is needed
    on Nov 11, 2020

  2. pavolloffay commented on Feb 8, 2021

    @pavolloffay
    pavolloffay
    on Feb 8, 2021
    MemberAuthor

    Missing tests:

    • apache async client
    • micronaut @shashank11p could you please paste here link to the issue in micronaut?

  3. shashank11p commented on Feb 8, 2021

    @shashank11p
    shashank11p
    on Feb 8, 2021
    Contributor

    Micronaut client issue for version 1.0.0 micronaut-projects/micronaut-core#4886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:testsgood first issueGood for newcomershelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions