You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Discrepancy with respect to OTel semantics in db call span #155
The semantics mandate the presence of net.peer.name or net.peer.ip and conditionally net.peer.port attributes.
These attributes are absent in the span reported by HT Java agent
Also, according to the Otel semantics the key for Span kind is span_kind
I assume the OTEL agent uses span_kind but then it gets converted to span.span in the OC service (collector). The platform should support span.kind orthogonally to this since it's a widely used tag.
Activity
findingrish commentedon Dec 5, 2020
Also, according to the Otel semantics the key for Span kind is
span_kindpavolloffay commentedon Dec 7, 2020
@rish691 could you please provide link/quote to spec where it mandates these attributes? Is it here https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/database.md
I assume the OTEL agent uses
span_kindbut then it gets converted tospan.spanin the OC service (collector). The platform should supportspan.kindorthogonally to this since it's a widely used tag.findingrish commentedon Dec 7, 2020
Additional attribute requirements: At least one of the following sets of attributes is required:
net.peer.name
net.peer.ip
pavolloffay commentedon Dec 7, 2020
Tracked upstream in open-telemetry/opentelemetry-java-instrumentation#1521
findingrish commentedon Dec 7, 2020
I have a pr on the platform to handle this. So, this issue shouldn't block our testing at the moment.
kotharironak commentedon Dec 14, 2020
I belive the change - https://github.com/hypertrace/hypertrace-ingester/pull/84/files - is supposed to do workaround.