Skip to content

hyperfiddle.electric-dom2/props reverses class order #73

Open

Description

@milelo

If I call:

(hyperfiddle.electric-dom2/props {:class "a b c"})

the dom shows: class="c b a".

Activity

  1. dustingetz commented on Aug 24, 2024

    @dustingetz
    Member

    Is it damaging something?

  2. milelo commented on Aug 25, 2024

    @milelo
    Author

    Potentially. If two classes have a conflicting style property for example color, the latter one takes precedence.

  3. dustingetz commented on Aug 26, 2024

    @dustingetz
    Member

    Thanks, we accept the bug. The root cause is that e/for mounts branches concurrently – they are racing. It is potentially straightforward to guarantee a mount ordering and we have been considering it.

  4. theronic commented on Dec 5, 2024

    @theronic
    Collaborator

    In Semantic UI, class names are order-dependent so e.g. (dom/props {:class "ui right aligned"}) renders to DOM as "aligned right ui", so I have to reverse the order to get text alignment working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions