Repository navigation
Update to emojilib 3 - #49
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
- Coverage 97.29% 97.16% -0.13%
==========================================
Files 2 2
Lines 111 106 -5
==========================================
- Hits 108 103 -5
Misses 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More emoji have been added to emojilib 3.0.2 since the last update to 2.4.0 in 2018 (and updated here in 2019 9171272).
However, 3.0.0 was a breaking change: muan/emojilib#178
Notably, the data structure and contents have changed, from:
to:
fitzpatrick_scaleis gone but it was never used. We no longer have a distinctcategory.The data is simpler: the "name" has basically been moved to the first keyword.
I've refactored the code to accommodate, and have aimed to have the same behaviour:
em piereturns 🥧, andem -s foodreturns a long list of food.However, there are some differences in the data, with the primary keyword changed in some cases. For example, "cake" is now "shortcake", and this matches https://emojipedia.org/shortcake/
I think this is fine, and means the emoji can be updated in the future as new emojilib updates come out. However, it's probably best to consider this a breaking change.
Please let me know if something now works differently that shouldn't (i.e. logic change rather than data change).