Repository navigation
Fix: modular image processors - #45492
Merged
zucchini-nlp merged 1 commit intoApr 20, 2026
Merged
Conversation
zucchini-nlp
commented
Apr 17, 2026
| ) | ||
|
|
||
|
|
||
| class LlavaOnevisionImageProcessorKwargs(ImagesKwargs, total=False): |
Member
Author
There was a problem hiding this comment.
already defined in L58-59, delete duplicate
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: llava_onevision |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
vasqu
approved these changes
Apr 17, 2026
| relative_dependency_order[dep], | ||
| # If this dependency is explicitly defined in the modular, prefer the modular's version. | ||
| # This prevents a renamed parent class from overriding a modular-defined class of the same name. | ||
| modular_mapper.global_nodes[dep] if dep in modular_mapper.classes else mapper.global_nodes[dep], |
Collaborator
There was a problem hiding this comment.
So this ternary was too gracious(?); makes sense to be more strict here
Member
Author
There was a problem hiding this comment.
Yeah, wasn't needed imo
Member
There was a problem hiding this comment.
AT least it leads to deviations
tarekziade
added a commit
that referenced
this pull request
Apr 20, 2026
This reverts commit cba1e40.
lvliang-intel
pushed a commit
to lvliang-intel/transformers
that referenced
this pull request
Apr 21, 2026
lvliang-intel
pushed a commit
to lvliang-intel/transformers
that referenced
this pull request
Apr 21, 2026
artem-spector
pushed a commit
to artem-spector/transformers
that referenced
this pull request
Apr 21, 2026
artem-spector
pushed a commit
to artem-spector/transformers
that referenced
this pull request
Apr 21, 2026
eustlb
pushed a commit
that referenced
this pull request
May 12, 2026
eustlb
pushed a commit
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Discovered in #45075
This was added in the recent image processing refactor, but was not reverted after fixing pkg requirements. We should not be defining the same class with identical name two times in modular, defining it once should copy in both files and resolve deps