Skip to content

handle multimodal models with tp_plan on the text_config - #39735

Closed
winglian wants to merge 1 commit into
huggingface:mainfrom
winglian:multimodal-tp
Closed

winglian wants to merge 1 commit into
huggingface:mainfrom
winglian:multimodal-tp

Conversation

@winglian

Copy link
Copy Markdown
Collaborator

What does this PR do?

Affects models like Gemma3

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Rocketknight1

Copy link
Copy Markdown
Member

cc @Cyrilvallez

@Cyrilvallez

Copy link
Copy Markdown
Member

Alright, but needs rebase to fix the conflict! 🤗

@ArthurZucker

Copy link
Copy Markdown
Collaborator

Thanks for the PR, and sorry it didn't make it in! This branch is based on v4, and v5 is very different, so rather than rebasing we'd love to invite you to open a new PR against main using our latest tools and good practices:

Closing this one in the meantime, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants