You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR resolves dynamic prefixes using the request path and the router’s captured parameter values. It also handles intermediate wildcards, including patterns such as /x*/y/*.
Although callers can work around this with replaceRequest, I think this is a case that mount() should handle by default. Since mount() was recently extracted from core into middleware, the additional code seems reasonable.
The implementation accesses the internal match result to obtain parameter values before param() decodes them. Those values are needed to calculate the correct offsets in the request path. This introduces a dependency on internal structures, but I think that is acceptable for middleware shipped with Hono.
❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review. ⚠️ Please upload report for BASE (v5@b0d28c4). Learn more about missing BASE report.
❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5546
This PR resolves dynamic prefixes using the request path and the router’s captured parameter values. It also handles intermediate wildcards, including patterns such as
/x*/y/*.Although callers can work around this with
replaceRequest, I think this is a case thatmount()should handle by default. Sincemount()was recently extracted from core into middleware, the additional code seems reasonable.The implementation accesses the internal match result to obtain parameter values before
param()decodes them. Those values are needed to calculate the correct offsets in the request path. This introduces a dependency on internal structures, but I think that is acceptable for middleware shipped with Hono.The author should do the following, if applicable
pnpm run check:fixto format and lint the code