You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(router): handle slashes after regex quantifiers - #5552
Route patterns such as /x/:prefix{a{2}/b}/x should match /x/aa/b/x, capturing aa/b as prefix.
Currently, pattern masking stops at the quantifier’s closing }, leaving the following / exposed to path splitting.
This is a fairly rare edge case, so I hesitated over whether it was worth adding code to support it. However, the routing syntax allows this pattern, so I’m opening this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route patterns such as
/x/:prefix{a{2}/b}/xshould match/x/aa/b/x, capturingaa/basprefix.Currently, pattern masking stops at the quantifier’s closing
}, leaving the following/exposed to path splitting.This is a fairly rare edge case, so I hesitated over whether it was worth adding code to support it. However, the routing syntax allows this pattern, so I’m opening this PR.
The author should do the following, if applicable
pnpm run check:fixto format and lint the code