Repository navigation
Conversation
…minators In JavaScript regex, '.' does not match line terminators (\n, \r, \u2028, \u2029) unless the 's' (dotAll) flag is set. When request paths contain encoded line terminators (such as %0A, %0D), decodeURI translates them into raw line terminators. As a result, wildcard routes (/* or *) in RegExpRouter failed to match and returned 404, while other routers matched correctly. This adds the 's' (dotAll) flag to the compiled RegExp in Trie.buildRegExp() and buildWildcardRegExp() in RegExpRouter, ensuring wildcard routes and middleware match paths containing line terminators. Fixes honojs#5345
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The author should do the following, if applicable
pnpm run check:fixto format and lint the codeDescription
In JavaScript regular expressions,
.does not match line terminators (\n,\r,\u2028,\u2029) unless thes(dotAll) flag is enabled.When request paths contain encoded line terminators (such as
%0A,%0D),getPath()runs them throughdecodeURI, converting them into raw line terminators before routing. Consequently, wildcard routes (such as/*or*) and middleware registered inRegExpRouterfailed to match and returned404 Not Found, while other routers (TrieRouter,LinearRouter,PatternRouter) matched correctly.This PR adds the
sflag and documentation to:Trie.buildRegExp()insrc/router/reg-exp-router/trie.tsbuildWildcardRegExp()insrc/router/reg-exp-router/router.tsAnd adds tests covering paths with all four JavaScript line terminators across
star,Trailing wildcard, and top-levelHonorequest handling.Closes #5345