Repository navigation
BE-930: Keep definition variables as $NAME SQL parameters - #10000
Draft
thehabbos007 wants to merge 1 commit into
Draft
thehabbos007 wants to merge 1 commit into
thehabbos007 wants to merge 1 commit into
Conversation
github-actions
Bot
added
area/libs
thehabbos007
added this pull request to stack #9985
October 12, 2026 14:49
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
thehabbos007
force-pushed
the
asa/hash-integrations/03c-definition-sql-parameters
branch
from
October 13, 2026 07:45
0978361 to
05b648f
Compare
thehabbos007
force-pushed
the
asa/hash-integrations/03c-definition-sql-parameters
branch
from
October 13, 2026 09:05
05b648f to
b1b0fa0
Compare
thehabbos007
force-pushed
the
asa/hash-integrations/03c-definition-sql-parameters
branch
from
October 13, 2026 10:15
b1b0fa0 to
7a3a9ed
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌟 Purpose
Lowering replaced
${NAME}in SQL with the variable's value, so the value became part of the query text. SQL is now kept as written and reads variables as DuckDB parameters,$NAME, which DuckDB binds as values.🔍 Changes
Definition::variables()returns the newVariablestype. It refuses two names that differ only in ASCII case, because DuckDB matches parameter names that way, and lowering reports the pair atvars.<name>.${NAME}placeholders outside SQL are still replaced. They now match names regardless of ASCII case, throughVariableName::matches.SqlQuerystores aBox<str>.$NAMEparameter is reported only when the query runs.