Repository navigation
Migrate user-facing APOD links to science.nasa.gov/apod - #52
Merged
Merged
Conversation
APOD's main site is moving from apod.nasa.gov to science.nasa.gov/apod (#47). Update all user-facing links back to APOD across the email content, signup templates, and public site: - Email footer: Archive -> science.nasa.gov/apod/archive, About APOD -> science.nasa.gov/apod/apod-about/ (verified live) - Native-video fallback card: per-day apYYMMDD.html deep links 404 on the new site (no date-addressable URLs), so link the APOD home - Signup confirmation template and public site nav -> new APOD home - preview_apod_email.js and tracked preview snapshots updated to match Deliberately unchanged: the scraper (apodScraper.js) still targets apod.nasa.gov, which still returns HTTP 200 — per the decision in #47 to keep DOM parsing as the primary ingestion mechanism and not switch to the NASA APOD API. New-site deep links and image assets have no new-host equivalents, so ingestion URLs stay as-is. Addresses #47
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #47.
What changed
All user-facing links back to APOD now point at the new site (
science.nasa.gov/apod), per the build instruction in #47:src/services/apodService.js): Archive →https://science.nasa.gov/apod/archive, About APOD →https://science.nasa.gov/apod/apod-about/(both verified live, HTTP 200)apYYMMDD.html, which 404s on the new site (it has no date-addressable per-day URLs), so it now links to the APOD homesrc/templates/added-email.html) and public site nav (public/index.html→ "Official APOD"): now link the new APOD homepreview_apod_email.jsand the tracked preview snapshots updated to matchDeliberately unchanged
src/services/apodScraper.jsstill scrapesapod.nasa.gov— per the decision in #47 to keep DOM parsing as the primary ingestion mechanism and not switch to the NASA APOD API. The classic date-based URLs still return HTTP 200, and the new site has no equivalent deep URLs, image-asset hosts, or scrapable DOM, so ingestion URLs stay as-is. Explanation-content deep links (other APOD days referenced inside explanation text) are also unchanged — they still resolve on the old host.Verification
npm test: 7 files, 28 tests, all passingscience.nasa.gov/apod/(200),/apod/archive(200),/apod/apod-about/(200)Follow-ups (not in this PR)
fetchAPOD(), per gtracy's comment