Skip to content

JsArrayList.contains() doesn't work in IE8 #4

Open

Description

@ks280first

Evidently IE 8 and earlier is missing Array.indexOf() which causes JsArrayList.contains() to break.

Fix was simple once I figured out what was going on. Maybe this could be included in the implementation.

<script> if (!Array.prototype.indexOf) { Array.prototype.indexOf = function(elt /*, from*/) { var len = this.length >>> 0; var from = Number(arguments[1]) || 0; from = (from < 0) ? Math.ceil(from) : Math.floor(from); if (from < 0) from += len; for (; from < len; from++) { if (from in this && this[from] === elt) return from; } return -1; }; } </script>

Activity

  1. reinert commented on Feb 4, 2015

    @reinert
    Member

    I would happily accept a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions