Repository navigation
Conversation
…lity New tests cover main(), the JSON/Markdown companions, error markers in subdirectories, directory batching, citation lists, request error mapping and the logging configuration. Two of them exposed defects: - requests' exceptions derive from IOError, so a timeout or connection error was caught by the "failed to open file" handler and recorded as a 400 marker with a misleading message. The handlers are now ordered most specific first and ReadTimeout maps to 408 as intended. - PDFs were eligible inputs for processCitationList and were read as text by process_txt. That service now only accepts .txt files.
Any .txt was an eligible input for processCitationList, including the <stem>_<status>.txt markers written next to the inputs when no output directory is given. A rerun posted the previous run's markers as citation lists, producing marker-of-marker files and inflated counts. PDFs are no longer eligible for this service either, since process_txt reads them as text and fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.