Python 3.x (x < 6): 'get_body(response)' returns bytes to 'json.loads()' #12

Activity

1. dhermes commented on Jul 13, 2017

   

   dhermes

   on Jul 13, 2017

   Last edited by dhermes

   Contributor

   More actions

   I should probably just evict this json.loads() code all together:

   json_response = json.loads(self._get_body(response))
   self._bytes_uploaded = int(json_response[u'size'])

   I had thought it was "universal" that all APIs return size but IIRC even the BigQuery API does not (so this code block would need to change before #3555 can be successfully merged).
2. dhermes

   added

   bug

   on Jul 13, 2017
3. dhermes

   self-assigned this

   on Jul 13, 2017
4. dhermes

   added

   upload

   on Jul 13, 2017
5. dhermes

   added 2 commits that reference this issue on Jul 18, 2017

   Making sure we pass unicode to `json.loads()` rather than `bytes`.

   ...

   This issue will close once commit 7f512de is merged into the 'master' branch.

   7f512de

   Making sure we pass unicode to `json.loads()` rather than `bytes`.

   ...

   This issue will close once commit 5e32675 is merged into the 'master' branch.

   5e32675
6. dhermes

   closed this as completedin #13on Jul 18, 2017
7. dhermes

   added a commit that references this issue on Jul 18, 2017

   Making sure we pass unicode to `json.loads()` rather than `bytes`.

   ...

   This issue will close once commit aff1642 is merged into the 'main' branch.

   aff1642
8. tseaver

   added

   type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

   and removed

   bug

   on Jan 16, 2019
9. yoshi-automation

   added

   🚨This issue needs some love.This issue needs some love.

   triage meI really want to be triaged.I really want to be triaged.

   on Apr 6, 2020