Repository navigation
Start project to publish pb2 generated modules for services we depend on. #1384
Description
See #1317 for context
It's also possible that the owners of googleapis-common-protobufs will publish this
/cc @tbetbetbe
{{ message }}
Activity
tbetbetbe commentedon Jan 15, 2016
We're going to start doing this from next week. The capability is already there now, but there are breaking changes in the gRPC client surface in v0.12, so we'll start next week once gRPC 0.12 packages are published
dhermes commentedon Jan 15, 2016
We'd like to rely on them with gRPC as an optional dependency, e.g. for
datastore.Is this a possibility or at least putting the proto message definitions in separate modules than the gRPC service definitions?
dhermes commentedon Jan 15, 2016
Also is there some public code or issue tracker or repo we can follow along with?
dhermes commentedon Feb 10, 2016
@tbetbetbe Any updates here?
Upgrading Makefile to generate datastore v1beta3.
tbetbetbe commentedon Feb 19, 2016
FYI: @nathanielmanistaatgoogle, there is a grpc issue tracking part of this grpc/grpc#3866, will you open another to track the actual split ?
dhermes commentedon Feb 19, 2016
Thanks for the update!
tseaver commentedon Aug 18, 2016
Logging and Pubsub already have releases of GAX and grpc wrappers.
dhermes commentedon Aug 18, 2016
Are these different than GAX? Do similar ones exist for Datastore and Bigtable?
tseaver commentedon Aug 18, 2016
The
grpc-google-pubsub-v1andgrpc-google-logging-v2wrappers are generated straight from the.protofiles with thegrpcplugin enabled. The GAX wrappers (gax-google-pubsub-v1andgax-google-logging-v2) depend on them, and provide a somewhat smoother surface.18 remaining items
bjwatson commentedon Aug 19, 2016
The index I just created includes links to docs on http://pythonhosted.org/. We currently only have Pub/Sub and Logging there, but plan to automate doc generation so we can easily do it for all APIs.
daspecster commentedon Aug 19, 2016
The docs on pythonhosed.org look nice! I could use the Vision ones any time 👍.
The docstrings and README for gax-google-cloud-vision could use some deeper examples. Like actually building a request. Although this could probably go in grpc-google-cloud-vision. Either place really I suppose but it would be nice to have it all in one spot.
bjwatson commentedon Aug 19, 2016
Thanks! Sphinx does a lot of the heavy lifting to help the readability. @geigerj can you push docs to pythonhosted for Vision as a one-off?
@daspecster Do you think there's something that could be done in auto-gen to improve the documentation, or is your feedback more for the Vision team to improve the documentation in their protos?
geigerj commentedon Aug 19, 2016
Vision docs pushed to here: https://pythonhosted.org/gax-google-cloud-vision-v1
Note that right now, the docs require some manual effort per-upload because the code generator does not always format the docstrings in a way that Sphinx understands; we're tracking those issues (at googleapis/gapic-generator#401, googleapis/gapic-generator#402) so that we can automate doc generation in the future.
daspecster commentedon Aug 23, 2016
@bjwatson @geigerj I think the pythonhosted.org stuff will work well enough for me if a full example was in them.
Either here http://pythonhosted.org/gax-google-cloud-vision-v1/google.cloud.vision.v1.image_annotator_api.html or here http://pythonhosted.org/gax-google-cloud-vision-v1/starting.html#examples
bjwatson commentedon Aug 23, 2016
@daspecster I created an issue to improve our auto-gen sample for that method: https://github.com/googleapis/googleapis/issues/99
For your purpose, however, it would probably be faster if you looked at existing samples like https://github.com/GoogleCloudPlatform/cloud-vision/blob/master/python/face_detection/faces.py, and adapt this to the GAX surface. There's not much we were able to do in the GAX surface, due to the structure of this API (single method with very rich argument structure), so it should be a straightforward mapping. Please let me know if you have any questions.
bjwatson commentedon Aug 23, 2016
What's left to be done to close this issue? Filling in all the TBDs in https://github.com/googleapis/googleapis/blob/master/PACKAGES.md with package links? Anything else?
dhermes commentedon Aug 23, 2016
It's fine to close since there is a dedicated team for this very purpose.
Where do we file issues for new services? (e.g. #2128 is still something we want / need)
bjwatson commentedon Aug 23, 2016
You can file such issues here and assign them to me. This seems more appropriate than any of the
googleapisrepos.dhermes commentedon Aug 23, 2016
Great thanks!
chore(deps): update dependency setuptools to v63.4.1 (#1384)
fix: Trust boundary meta header renaming and using the schema from ba…
chore: add sample to set statement timeout within a transaciton (#1384)