You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expose 'upload' class from 'upload_from_file()' #1077
When uploading a large file with the Blob.upload_from_file() method it would be extremely convenient to be able to access properties of the upload class that is generated in this method to view upload progress, as well as assert the other properties of that wrapped class.
Adding upload as an instance attribute of the blob object doesn't make much sense: it is a transient local only to the call. We could return the Upload instance created, though.
What about the users who don't care about messing with it? the current implementation serves them, at the expense of the OP's request. If we don't do the actual streaming inside upload_from_*, we make those users have to deal with it.
Hello,
One of the challenges of maintaining a large open source project is that sometimes, you can bite off more than you can chew. As the lead maintainer of google-cloud-python, I can definitely say that I have let the issues here pile up.
As part of trying to get things under control (as well as to empower us to provide better customer service in the future), I am declaring a "bankruptcy" of sorts on many of the old issues, especially those likely to have been addressed or made obsolete by more recent updates.
My goal is to close stale issues whose relevance or solution is no longer immediately evident, and which appear to be of lower importance. I believe in good faith that this is one of those issues, but I am scanning quickly and may occasionally be wrong. If this is an issue of high importance, please comment here and we will reconsider. If this is an issue whose solution is trivial, please consider providing a pull request.
Activity
dhermes commentedon Aug 24, 2015
This is somewhat tied in with #935. Thanks for filing, we hope to be able to get on this soon-ish.
tseaver commentedon Aug 24, 2015
Adding
uploadas an instance attribute of the blob object doesn't make much sense: it is a transient local only to the call. We could return theUploadinstance created, though.dhermes commentedon Dec 31, 2015
👍 To returning the
Uploadinstance. @tseaver How does this fit in with thegcloud.streamingchanges?tseaver commentedon Jan 7, 2016
What about the users who don't care about messing with it? the current implementation serves them, at the expense of the OP's request. If we don't do the actual streaming inside
upload_from_*, we make those users have to deal with it.dhermes commentedon Jan 7, 2016
Maybe there is a middleground? A flag that will disable it? Or a simple wrapper that they can consume, like a query iterator or otherwise.
lukesneeringer commentedon Aug 11, 2017
Hello,
One of the challenges of maintaining a large open source project is that sometimes, you can bite off more than you can chew. As the lead maintainer of
google-cloud-python, I can definitely say that I have let the issues here pile up.As part of trying to get things under control (as well as to empower us to provide better customer service in the future), I am declaring a "bankruptcy" of sorts on many of the old issues, especially those likely to have been addressed or made obsolete by more recent updates.
My goal is to close stale issues whose relevance or solution is no longer immediately evident, and which appear to be of lower importance. I believe in good faith that this is one of those issues, but I am scanning quickly and may occasionally be wrong. If this is an issue of high importance, please comment here and we will reconsider. If this is an issue whose solution is trivial, please consider providing a pull request.
Thank you!
PetrochukM commentedon Jun 21, 2019
Please reopen this. This has not been tackled many years later. What is the mechanism for exposing upload progress?
chore: release 0.56.1 (#1077)
chore: Update gapic-generator-python to 1.26.2 (#1077)
fix: there was a raise missing for throwing exceptions (#1077)
chore(main): release 2.19.3 (#1077)