Skip to content
This repository was archived by the owner on Aug 25, 2026. It is now read-only.
This repository was archived by the owner on Aug 25, 2026. It is now read-only.

Some tests are missing port in comparison #872

Closed

Description

@busunkim96

Noticed in googleapis/python-aiplatform#377

Correct:

create_channel.assert_called_with(
"{{ host }}{% if ":" not in service.host %}:443{% endif %}",

Missing:

create_channel.assert_called_with(
"{{ host }}",

Activity

  1. added
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    priority: p2Moderately-important priority. Fix may not be included in next release.
    on May 10, 2021
  2. self-assigned this
    on May 10, 2021
  3. changed the title [-]Some tests are missing optional port in comparison[/-] [+]Some tests are missing port in comparison[/+] on May 10, 2021
  4. added a commit that references this issue on May 12, 2021
    40078c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions