Skip to content
This repository was archived by the owner on May 29, 2026. It is now read-only.
This repository was archived by the owner on May 29, 2026. It is now read-only.

Use HasSuffix instead of trying to manually calculate test suffix presence. #294

Open
Open
Use HasSuffix instead of trying to manually calculate test suffix presence.#294

Description

@eldondevat
eldondevat
opened on Nov 25, 2025

Can get an out-of-bounds exception at the end of go/database/sql/connection.go if sqlcommenter is asked to comment an empty line/zero-length sql string/comment.

Activity

  1. eldondevat commented on Nov 25, 2025

    @eldondevat
    eldondevat
    on Nov 25, 2025
    Author

    @duffn Any interest here? Seems that this can happen sometimes in the context of commenting migrations run by https://github.com/rubenv/sql-migrate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions