This repository was archived by the owner on Sep 4, 2025. It is now read-only.
Repository navigation
This repository was archived by the owner on Sep 4, 2025. It is now read-only.
Nested structs not being Unmarshaled #49
Description
Given a struct that contains another struct:
type Address struct {
City string `jsonapi:"attr,city" json:"city"`
State string `jsonapi:"attr,state" json:"state"`
}
type AdditionalInfo struct {
HomeAddress *Address `jsonapi:"attr,homeaddress" json:"homeaddress"`
Phone *string `jsonapi:"attr,phone" json:"phone"`
}
When calling UnmarshalPayload with this json:
{
"homeaddress": {
"city": "brooklyn",
"state": "NY"
},
"phone": "555-555-5555"
}
I get an error data is not a jsonapi representation of AdditionalInfo. Are nested structs not supported?
Activity
aren55555 commentedon Aug 31, 2016
Your payload is not valid JSON API; even if it was (see below) I don't believe the nested struct is supported.
{ "data": { "type": "info", "attributes": { "phone": "555-555-5555", "homeaddress": { "city": "brooklyn", "state": "NY" } } } }If you want, please submit a PR adding support for this feature. Please ensure the implementation follow the JSON API spec's Attributes guidelines:
iderdik commentedon Sep 1, 2016
Sorry about that - my actual json was valid jsonAPI, I had just extracted the relevant part of the
attributeskey.In any case, I seem to have gotten the functionality I need by declaring the type of HomeAddress to be a
map[string]interface{}and handling any conversions betweenmapandstructelsewhere. It's obviously not ideal but it's all I have right now.I'll leave the feature request open because I still think it would be valuable to have nested struct handling. Perhaps someone else reading this might be able to pick it up and work on it.
bensullivan commentedon Sep 17, 2016
+1 for this feature please
shwoodard commentedon Sep 22, 2016
Dup of #21
iderdik commentedon Sep 22, 2016
#21 is more about embedded anonymous structs. This issue is about structs as a field in a struct.
msabramo commentedon Jan 18, 2018
See #99 and mrowdy#3, which fixes pointers to struct fields.