Repository navigation
Keep weighted_distribution_ in sync with records_ when pruning all-zero weights. - #2275
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
cl/1000889284
branch
2 times, most recently
from
October 19, 2026 20:41
c16dfdd to
b1576ee
Compare
…l-zero weights. When all corpus inputs have weight zero, `WeightedDistribution::RemoveRandomWeightedSubset` removes every entry from `weighted_distribution_` before returning `subset_to_remove`. `Corpus::Prune` then erases one index from `subset_to_remove` so `records_` retains one random input, leaving `weighted_distribution_` empty and causing check failures on subsequent corpus operations. Restore one zero weight in `weighted_distribution_` when keeping that fallback input, and add a unit test covering `Corpus::Prune` with all-zero weights. PiperOrigin-RevId: 1002585725
copybara-service
Bot
force-pushed
the
cl/1000889284
branch
from
October 19, 2026 21:14
b1576ee to
7a6384e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep
weighted_distribution_in sync withrecords_when pruning all-zero weights.When all corpus inputs have weight zero,
WeightedDistribution::RemoveRandomWeightedSubsetremoves every entry fromweighted_distribution_before returningsubset_to_remove.Corpus::Prunethen erases one index fromsubset_to_removesorecords_retains one random input, leavingweighted_distribution_empty and causing check failures on subsequent corpus operations.Restore one zero weight in
weighted_distribution_when keeping that fallback input, and add a unit test coveringCorpus::Prunewith all-zero weights.