Repository navigation
[typing] add assertion to avoid pyrefly error - #5546
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_960258175
branch
2 times, most recently
from
August 6, 2026 13:40
b74d6ba to
f871f84
Compare
`sampling_state.logits_buffer` is annotated as `jnp.ndarray | None`, so strict typing requires this assertion. This is not an issue at runtime, because the `None` case would result in an uncaught `AttributeError` in the next line. PiperOrigin-RevId: 960267676
copybara-service
Bot
force-pushed
the
test_960258175
branch
from
August 6, 2026 13:41
f871f84 to
6d224f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[typing] add assertion to avoid pyrefly error
sampling_state.logits_bufferis annotated asjnp.ndarray | None, so strict typing requires this assertion. This is not an issue at runtime, because theNonecase would result in an uncaughtAttributeErrorin the next line.