Repository navigation
Use less precise numbers in linen doctest - #5526
Merged
Merged
Conversation
cgarciae
approved these changes
Jul 6, 2026
samanklesaria
force-pushed
the
fix_ci_precision
branch
from
July 6, 2026 23:24
2436116 to
e2d7ba2
Compare
cgarciae
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should fix the doctests on main, which are broken due to a numerical precision issue- what we see (0.04579117) is only very slightly different from what we expect (0.04579116). It seems this could be addressed by expecting a slightly less precise number (0.0457912), along with the "NUMBER" flag when running doctests to enable dynamic precision.