Repository navigation
replace bare asserts with ValueError in NNX attention validation - #5505
Merged
copybara-service[bot] merged 1 commit intoJun 26, 2026
Merged
copybara-service[bot] merged 1 commit into
copybara-service[bot] merged 1 commit into
Conversation
vfdev-5
reviewed
Jun 16, 2026
vfdev-5
left a comment
vfdev-5
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @mohsinm-dev , I left few comments
mohsinm-dev
force-pushed
the
fix-attention-assert-to-valueerror
branch
from
June 16, 2026 09:47
a5984ea to
407fb86
Compare
vfdev-5
reviewed
Jun 16, 2026
mohsinm-dev
force-pushed
the
fix-attention-assert-to-valueerror
branch
from
June 16, 2026 10:01
407fb86 to
d2360a4
Compare
vfdev-5
force-pushed
the
fix-attention-assert-to-valueerror
branch
from
June 17, 2026 20:58
d2360a4 to
4f85c88
Compare
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5496
dot_product_attention,dot_product_attention_weights, andcombine_masksused bareassertfor input shape validation. Underpython -O, these are stripped and invalid inputs silently produce wrong-shaped output on the dropout/module path.Replaced with
if/raise ValueError. Also removed one dead-code assert in the non-GQA else branch where the condition was already guaranteed by the enclosing if/else.