Repository navigation
Fix rnglib doctests for graph_updates=False default - #5442
Merged
copybara-service[bot] merged 1 commit intoMay 12, 2026
Merged
Conversation
samanklesaria
force-pushed
the
fix-rnglib-doctest
branch
4 times, most recently
from
April 29, 2026 21:57
ad21703 to
aeab2fd
Compare
samanklesaria
force-pushed
the
fix-rnglib-doctest
branch
from
April 29, 2026 22:03
aeab2fd to
4ef656d
Compare
samanklesaria
force-pushed
the
fix-rnglib-doctest
branch
from
April 30, 2026 15:33
4ef656d to
9a36041
Compare
IvyZX
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With graph_updates=False, split_rngs docstrings breaks. This PR documents the fact that the API with graph_updates=False is totally different, and ensures that the doctests use the graph_updates=False argument when needed.