Repository navigation
Fix for change to jax.Array.__contains__ - #5404
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_897742632
branch
2 times, most recently
from
April 10, 2026 18:04
666f421 to
5adabe5
Compare
In jax-ml/jax#36655 JAX updates the implementation of `jax.Array.__contains__`, which makes `val in array` more efficient. As part of this, JAX will become more strict in what types it allows; e.g. `string in array` will raise an error rather than returning `False`. This update future-proofs code in preparation for this change. PiperOrigin-RevId: 897791321
copybara-service
Bot
force-pushed
the
test_897742632
branch
from
April 10, 2026 18:18
5adabe5 to
64aa65a
Compare
2 of 4 tasks
aalquwayfili
added a commit
to aalquwayfili/flax
that referenced
this pull request
Oct 11, 2026
google#5404 guarded the `OVERWRITE_WITH_GRADIENT in params` check in `create`, but `apply_gradients` does the same check twice. With an array JAX now raises `TypeError: Array.__contains__: unsupported operand type <class 'str'>`, so use the same guard there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for change to
jax.Array.__contains__In jax-ml/jax#36655 JAX updates the implementation of
jax.Array.__contains__, which makesval in arraymore efficient.As part of this, JAX will become more strict in what types it allows; e.g.
string in arraywill raise an error rather than returningFalse.This update future-proofs code in preparation for this change.