Repository navigation
fix Rngs.__getattr__ returning default stream for dunder names (#5375) - #5379
Merged
copybara-service[bot] merged 1 commit intoApr 13, 2026
Merged
Conversation
samanklesaria
force-pushed
the
fix-rngs-dunder-getattr
branch
from
March 31, 2026 17:30
c7b5bf0 to
fef7722
Compare
samanklesaria
approved these changes
Mar 31, 2026
samanklesaria
force-pushed
the
fix-rngs-dunder-getattr
branch
from
April 7, 2026 21:26
fef7722 to
4f6b33f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5375
Rngs.__getattr__falls back to returning the defaultRngStreamfor any attribute name not explicitlydefined, including dunder names like
__pydantic_serializer__. This breaks any library that probes forprotocol support via
hasattr/getattron dunder names.Added an early guard in
__getattr__to raiseAttributeErrorfor dunder names so only user-chosenstream names trigger the fallback.