Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
==========================================
+ Coverage 93.17% 93.61% +0.43%
==========================================
Files 26 26
Lines 3339 3428 +89
==========================================
+ Hits 3111 3209 +98
+ Misses 228 219 -9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
m4tx
changed the title
Currently, `Fdt::new` does a strict validation of node and property names. According to the DTB spec, these names cannot exceed 31 characters in length. However, in practice, many DTBs do (including ones typically used in Linux), and `dtc` doesn't reject such trees when compiling DTS files. This adds `with_options` method to `Fdt` that allows to specify the exact behaviour. The default is to allow names exceeding 31 characters; UTF-8 validity is still checked. Recently added `from_raw_bounded` was also replaced with this. Fixes #101
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
Fdt::newdoes a strict validation of node and property names. According to the DTB spec, these names cannot exceed 31 characters in length. However, in practice, many DTBs do (including ones typically used in Linux), anddtcdoesn't reject such trees when compiling DTS files.This adds
with_optionsmethod toFdtthat allows to specify the exact behaviour. The default is to allow names exceeding 31 characters; UTF-8 validity is still checked.Recently added
from_raw_boundedwas also replaced with this.Fixes #101