Skip to content

Show the remove-duplicate button to non-admins as disabled #5503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ViniciustCosta merged 3 commits into from
Sep 30, 2026
Merged

Show the remove-duplicate button to non-admins as disabled #5503

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea1954f
Show remove-duplicate button to non-admins as disabled
atty57 Sep 28, 2026
44a12c7
Merge branch 'master' into fix-5452-remove-duplicate-button-visibility
dylanjew Sep 29, 2026
8c22d5e
Merge branch 'master' into fix-5452-remove-duplicate-button-visibility
dylanjew Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/appengine/private/components/testcase-detail/testcase-detail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,9 +435,9 @@
<if-else condition="[[shouldShowDuplicateStatus(info)]]">
<span slot="t">
<a href="/testcase-detail/[[info.testcase.duplicate_of]]">Duplicate of testcase [[info.testcase.duplicate_of]]</a>
<template is="dom-if" if="[[info.is_admin]]">
<paper-icon-button icon="highlight-off" toggles active="{{removeDuplicateDialogOpened}}" title="Remove the duplicate status"></paper-icon-button>
</template>
<span title="Remove the duplicate status (admin only).">
<paper-icon-button icon="highlight-off" toggles disabled$="[[!info.is_admin]]" active="{{removeDuplicateDialogOpened}}"></paper-icon-button>
</span>
</span>
<span slot="f">
<if-else condition="[[shouldShowPendingStatus(info)]]">
Expand Down
Loading