Repository navigation
Remove duplicate button is invisible to non-admins #5452
Description
This button:
is invisible to non-"admins" so it appears the functionality does not exist.
- It should be visible but disabled instead
- The text should describe it as an admin function for BOTH admins and non-admins so it's easier to communicate about
- It might be useful if it were not an admin function, because handling false dedups (in my case caused by a common flake) doesn't seem like it should be the responsibility of admins only. However I'm not sure whether I can achieve the same thing just through a "redo" - if that will unmark it as a duplicate once the flake goes away. If that's the case then this button should explain that as well.
Activity
Show the remove-duplicate button to non-admins as disabled (#5503)
dylanjew commentedon Oct 1, 2026
The UI issue is fixed now. But opening this behavior to non-admins is a bit tricky, I realized that it's dangerous to ungroup testcases because it can leave the data in a bad state. We can end up with two competing groups for the same crash and CF doesn't have any recovery mechanism for this. I think we've found that CF is not resilient to shallow/common flakes, unfortunately. Flakes in particular cause CF to short circuit and not finish analysis progression tasks.
Once the flake is fixed, grouping works correctly. We have crbug/559733324 to improve this
Going to mark this as fixed.