Repository navigation
Support keyboard shortcut for formatted Vs Unformatted paste - #60
Closed
zutshisunakshi wants to merge 6 commits into
Closed
zutshisunakshi wants to merge 6 commits into
zutshisunakshi wants to merge 6 commits into
Conversation
Contributor
Author
|
Open to feedback/thoughts on this approach Vs in #59 |
theinterned
reviewed
May 12, 2022
| @@ -0,0 +1,26 @@ | |||
| type UMap = WeakMap<HTMLElement, boolean> | |||
Contributor
There was a problem hiding this comment.
I think this name UMap could be more clear
| @@ -0,0 +1,26 @@ | |||
| type UMap = WeakMap<HTMLElement, boolean> | |||
| export class PasteKeyBoardShortcut { | |||
Contributor
There was a problem hiding this comment.
should this class (and the file name, and the instances) be something like PasteFormatSkipper?
Contributor
Author
|
Closing in support of #59 being better voted approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: https://github.com/github/special-projects/issues/966
Context:
Add support for keyboard shortcuts where when :
cmd/ctrl+ shift + vpastes unformatted content like for paste linkshttp://...andcmd/ctrl + vformatted auto linked link on selected text like[...](http://...)Screen.Recording.2022-05-11.at.11.27.58.PM.mov
Approach 2
This PR adds support for paste on using keyboard shortcuts - this approaches the fix by creating a class with required
keydownhandler/helper methods to toggle state which would decide when to paste formatted ( markdown ) content Vs not for a consistent paste.🍐 @theinterned