Repository navigation
fix: escape field IDs in hotkey scopes - #161
Open
feritcemkahraman wants to merge 1 commit into
Open
feritcemkahraman wants to merge 1 commit into
feritcemkahraman wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scoped hotkeys stop working when a form field's ID contains a quote or backslash. Quotes throw a selector SyntaxError; backslashes change the scope being matched.
Escape the ID when building the scope selector. Both regressions failed before the fix; all 102 Chromium tests, full ESLint and TypeScript checks now pass. The compiler/Rollup build also passes with the Unix cleanup hook skipped on Windows. Browser tests used a local config for cached Chromium, IPv4 ports and one worker; Firefox/WebKit were not run.