Allow two noop calls by default by Copilot · Pull Request #64031 · github/gh-aw

Copilot · 2026-09-28T14:56:30Z

The default single-call noop budget is too strict because an agent’s first call is often a probe. Increase the default to two calls while preserving explicit max overrides.

Changes

Raise implicit and explicit noop defaults from 1 to 2.
Align runtime validation and workflow schema metadata.
Update tests, reference documentation, and generated workflow locks.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 31.3 AIC · ⌖ 8.67 AIC · ⊞ 9.2K · ◷
_{Comment /souschef to run again}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-09-28T14:57:24Z

@copilot also detect probing requests and ignore

Copilot

Copilot review overview

🟢 Approval recommended

Compiler, runtime, schema, documentation, tests, and generated artifacts consistently apply the new default while retaining explicit overrides.

Review effort: Balanced
Findings: None

What changed in this PR

Raises the default noop budget from one to two calls, allowing a probe followed by a final response while preserving explicit overrides.

Changes:

Updates compiler, runtime validation, and schema defaults.
Adds Go and JavaScript regression coverage.
Refreshes documentation and generated workflow locks.

File	Description
`pkg/workflow/safe_outputs_validation_config.go`	Sets runtime default to two.
`pkg/workflow/safe_outputs_config_extraction.go`	Updates implicit noop configuration.
`pkg/workflow/safe_output_validation_config_test.go`	Tests validation default.
`pkg/workflow/noop.go`	Updates explicit noop parsing defaults.
`pkg/workflow/noop_test.go`	Updates parser expectations.
`pkg/workflow/maintenance_workflow_cron_test.go`	Verifies implicit noop budget.
`pkg/parser/schemas/main_workflow_schema.json`	Updates schema metadata and defaults.
`docs/src/content/docs/reference/safe-outputs.md`	Documents the new limit.
`docs/src/content/docs/reference/frontmatter-full.md`	Updates generated frontmatter reference.
`actions/setup/js/safe_output_type_validator.test.cjs`	Tests JavaScript runtime validation.
`.github/workflows/windows.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/windows-grower.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/weekly-network-domains-audit.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/video-analyzer.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/typist.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/test-quality-sentinel.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/super-linter.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/sub-issue-closer.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/stale-pr-cleanup.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/squad-plan.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/smoke-copilot-auto.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/skillet.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/sighthound-security-scan.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/scout.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/safe-output-health.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/repo-tree-map.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/release.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/refactoring-cadence.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/pr-description-caveman.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/pdf-summary.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/objective-impact-report.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/lockfile-stats.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/gpclean.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/go-pattern-detector.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/front-page-copy-guard.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/feature-grower.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/example-workflow-analyzer.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/example-failure-category-filter.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/draft-pr-cleanup.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/dev.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/dev-hawk.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/designer-drift-audit.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/deployment-incident-monitor.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/daily-windows-terminal-integration-builder.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/daily-team-status.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/daily-semgrep-scan.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/daily-observability-report.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/daily-model-resolution.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/daily-max-ai-credits-test.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/daily-grader-audit.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/daily-github-docs-seo-optimizer.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/daily-file-diet.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/daily-fact.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/daily-credit-limit-test.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/daily-choice-test.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/daily-cache-strategy-analyzer.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/daily-assign-issue-to-user.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/daily-action-setup-security-audit.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/copilot-pr-merged-report.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/commit-changes-analyzer.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/cli-consistency-checker.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/blog-auditor.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/archie.lock.yml`	Regenerates noop runtime settings.
`.github/workflows/agent-persona-explorer.lock.yml`	Regenerates noop runtime settings.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

gh-aw-bot · 2026-09-28T16:02:11Z

pr-sous-chef
@copilot Please address the latest maintainer follow-up on this PR, update the implementation if needed, and then run the pr-finisher skill before handing back for review.

New feedback landed after the last review pass: Allow two noop calls by default #64031 (comment)
The current Copilot review summary looks positive, so focus on the new follow-up and any resulting test/doc updates.
A branch refresh was requested from sous-chef for this run: https://github.com/github/gh-aw/actions/runs/36446087224

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 31.3 AIC · ⌖ 8.67 AIC · ⊞ 9.2K · ◷
_{Comment /souschef to run again}

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-09-28T16:25:00Z

@copilot also detect probing requests and ignore

Probing noop calls are now detected and ignored end to end:

MCP invocation time: a noop whose message is an obvious placeholder (test, probe, placeholder, dummy, todo, …) is dropped — not written to the safe-outputs file and not counted against the noop budget. This also prevents a probe from tripping the harness pre-flight "noop already written" skip.
Ingestion time: collect_ndjson_output applies the same filter as defence in depth for direct NDJSON writes.

Detection reuses the existing TRIVIAL_PROBE_VALUES set in intent_probe.cjs. Covered by unit tests in safe_outputs_handlers.test.cjs and collect_ndjson_output.test.cjs, and documented in docs/src/content/docs/reference/safe-outputs.md.

github-actions · 2026-09-28T17:07:48Z

Great work! 🎉 This PR looks ready for review. The change to raise default noop budgets from 1 to 2 is well-scoped and includes comprehensive test updates across 307 files, demonstrating thorough validation of the refactor. The PR description clearly articulates the rationale (first call is often a probe) and the implementation strategy (preserving explicit max overrides).

Generated by ✅ Contribution Check · copilot · auto · 49.4 AIC · ⌖ 8.07 AIC · ⊞ 9.1K · ◷

github-actions · 2026-09-28T23:28:24Z

🎉 This pull request is included in a new release.

Release: v0.90.0

Document two schema fields added after prior v0.89.21 sync passes: noop's `max` field (default now 2, from #64031) and custom safe-outputs jobs' `artifacts` field for declaring extra agent-written paths (#63017). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Copilot AI and others added 2 commits September 28, 2026 14:45

feat: allow two noop calls by default

edea6c5

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

fix: align noop schema default

bddb466

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI assigned Copilot and pelikhan Sep 28, 2026

Copilot AI changed the title ~~Make noop accept two calls by default~~ Allow two noop calls by default Sep 28, 2026

Copilot created this pull request from a session on behalf of pelikhan September 28, 2026 14:57

View session

Copilot finished work on behalf of pelikhan September 28, 2026 14:57

Copilot AI requested a review from pelikhan September 28, 2026 14:57

Copilot started work on behalf of pelikhan September 28, 2026 15:01

View session

pelikhan marked this pull request as ready for review September 28, 2026 15:03

Copilot AI balanced review requested due to automatic review settings September 28, 2026 15:03

Copilot started reviewing on behalf of pelikhan September 28, 2026 15:04

View session

Copilot AI reviewed Sep 28, 2026

View reviewed changes

feat: detect and ignore probing noop messages

f9e84b1

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan September 28, 2026 15:15

Merge branch 'main' into copilot/make-noop-more-lenient

4f5cd4d

github-actions Bot mentioned this pull request Sep 28, 2026

[pr-sous-chef] PR Sous Chef run report #63890

Closed

Copilot started work on behalf of gh-aw-bot September 28, 2026 16:11

View session

Copilot AI and others added 3 commits September 28, 2026 16:20

feat: skip noop budget for probing calls at MCP invocation time

b71462d

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

fix: drop probing noop calls at MCP invocation time

a9118e5

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

refactor: extract probing noop guard helper

e7a1890

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot September 28, 2026 16:25

Copilot AI requested a review from gh-aw-bot September 28, 2026 16:25

github-actions Bot mentioned this pull request Sep 28, 2026

[Contribution Check Report] Contribution Check — 2026-09-28 #63900

Closed

pelikhan merged commit 5260b72 into main Sep 28, 2026
45 checks passed

pelikhan deleted the copilot/make-noop-more-lenient branch September 28, 2026 17:12

This was referenced Sep 29, 2026

[instructions] Sync instruction files with release v0.89.21 (follow-ups) #64228

Merged

[docs] Update glossary - daily scan #64244

Merged

Navigation Menu

Repository navigation

Allow two noop calls by default - #64031

Allow two noop calls by default#64031
pelikhan merged 7 commits into
mainfrom
copilot/make-noop-more-lenient

Copilot AI commented Sep 28, 2026 •

edited by github-actions Bot

Loading

Uh oh!

pelikhan commented Sep 28, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

gh-aw-bot commented Sep 28, 2026

Uh oh!

Copilot AI commented Sep 28, 2026

Uh oh!

github-actions Bot commented Sep 28, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 28, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Copilot AI commented Sep 28, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

pelikhan commented Sep 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

gh-aw-bot commented Sep 28, 2026

Uh oh!

Copilot AI commented Sep 28, 2026

Uh oh!

github-actions Bot commented Sep 28, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 28, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Sep 28, 2026 •

edited by github-actions Bot

Loading