Repository navigation
Conversation
Use upstream's standalone_toolchain for Xcode instead of a separate local, configuring repository rule that refetches the pinned download on every server restart. Keep the SDK lookup and path watch. Publish rules_swift as 4.0.0-rc5-codeql.3 and regenerate registry metadata. Rebase the external static runtime patch onto upstream's inline attributes so the patches apply in the generated order. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 477ddbb2-ed60-4303-bada-daa9aecee456
jketema
added
the
depends on internal PR
jketema
marked this pull request as ready for review
October 28, 2026 13:34
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Xcode selection changes are not tracked, so the cached sdkroot can keep pointing to the previous SDK even after a Bazel restart while that SDK remains installed.
No open issues 🎉
What changed in this PR
This PR reuses upstream’s standalone repository rule for the downloaded Xcode Swift toolchain to avoid refetching it across Bazel server restarts.
Changes:
- Removes the separate local/configuring macOS rule while retaining SDK lookup and path watching.
- Updates the custom
rules_swiftrelease to4.0.0-rc5-codeql.3. - Rebases the external static runtime patch and refreshes patch ordering and integrity metadata.
| File | Description |
|---|---|
MODULE.bazel |
Selects the updated rules_swift release. |
misc/bazel/registry/modules/rules_swift/metadata.json |
Lists the updated custom release. |
misc/bazel/registry/modules/rules_swift/4.0.0-rc5-codeql.3/source.json |
Updates patch ordering and integrity hashes. |
misc/bazel/registry/modules/rules_swift/4.0.0-rc5-codeql.3/patches/register_downloaded_macos_toolchain.patch |
Removes the local macOS rule while preserving SDK discovery. |
misc/bazel/registry/modules/rules_swift/4.0.0-rc5-codeql.3/patches/external_static_runtime.patch |
Rebases runtime support onto upstream’s inline attributes. |
misc/bazel/registry/modules/rules_swift/4.0.0-rc5-codeql.3/MODULE.bazel |
Declares the updated custom release version. |
Review effort: Max
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use upstream's standalone_toolchain for Xcode instead of a separate local, configuring repository rule that refetches the pinned download on every server restart. Keep the SDK lookup and path watch.
Publish rules_swift as 4.0.0-rc5-codeql.3 and regenerate registry metadata. Rebase the external static runtime patch onto upstream's inline attributes so the patches apply in the generated order.
CI failures are expected.