Repository navigation
Bump undici override to the latest 7.x version - #4268
Merged
Merged
Conversation
henrymercer
reviewed
Oct 27, 2026
| "license": "MIT", | ||
| "engines": { | ||
| "node": ">=18.17" | ||
| "node": ">=20.18.1" |
Contributor
There was a problem hiding this comment.
Did you check that the >=20.18.1 Node version aligns with the runner versions we support (those shipped with the GHES versions we support)?
Member
Author
There was a problem hiding this comment.
The oldest GHES we support is now 3.19 which ships with 20.19.4 so I think this is fine. (For the record, 3.18 before that shipped with 20.19.1 which would also have been fine).
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The global override forces Undici 7 onto consumers declaring 5.x or 6.x requirements, and compatibility remains unverified.
No open issues 🎉
1 file not reviewed
lib/entry-points.js: Excluded by your content exclusion settings
What changed in this PR
Updates the CodeQL Action’s Undici dependency and global override, while shifting future Undici updates to manual maintenance.
Changes:
- Upgrades Undici from 6.28.0 to 7.30.1 and updates the lockfile.
- Adds a Dependabot ignore rule for Undici versions
>=7.30.1, with comments explaining manual updates.
| File | Description |
|---|---|
package.json |
Updates the direct Undici dependency and global override. |
package-lock.json |
Records Undici 7.30.1 and its higher minimum Node.js requirement. |
.github/dependabot.yml |
Adds and documents the Undici update exclusion. |
Review effort: Max
henrymercer
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
undicito a newer version, including the override. We have at least one dependency that is lagging behind with a5.xrequirement onundicithat we can't shed.