Skip to content

[BUGFIX] #244 Fix removing belongsTo relations - #245

Merged
HennerM merged 2 commits into
ghidoz:masterfrom
frans-beech-it:244-fix-removing-belongsTo-relation
Oct 12, 2020
Merged

HennerM merged 2 commits into
ghidoz:masterfrom
frans-beech-it:244-fix-removing-belongsTo-relation

Conversation

@frans-beech-it

Copy link
Copy Markdown
Contributor

No description provided.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.6%) to 90.995% when pulling 20e8b93 on frans-beech-it:244-fix-removing-belongsTo-relation into 5c2ede1 on ghidoz:master.

@frans-beech-it

Copy link
Copy Markdown
Contributor Author

related to #148

@n2ygk

n2ygk commented Nov 26, 2019 •

Copy link
Copy Markdown

@frans-beech-it I am experiencing this issue as well. I have what I think is a very common use case in which the parent model has an optional singular child relationship. My use case is that I add a relationship and then want to remove it which I do by setting relationship to null. The resulting PATCH payload leaves it out rather than setting it to "rel_name": {"data": null} per the JSONAPI spec

I'm guessing this PR is because progress stalled on #148?

@fsaris

fsaris commented Nov 26, 2019

Copy link
Copy Markdown
Collaborator

I'm not sure if #148 is still relevant. But my pr resolves this issue. You can try is in your own project by pasting the 2 methods touched in this PR in your own datastore service.

Will try to add some tests to this soon so hopefully this can be merged.

@n2ygk

n2ygk commented Nov 26, 2019

Copy link
Copy Markdown

I'm not sure if #148 is still relevant. But my pr resolves this issue. You can try is in your own project by pasting the 2 methods touched in this PR in your own datastore service.

Will try to add some tests to this soon so hopefully this can be merged.

@fsaris Yep, grabbed getRelationships and updateRelationships and it works great. Thanks!

@n2ygk

n2ygk commented Feb 14, 2020

Copy link
Copy Markdown

@fsaris @frans-beech-it Any progress on merging this?

@bosk59

bosk59 commented Feb 25, 2020

Copy link
Copy Markdown

Waiting for a merge too....

@frans-beech-it

Copy link
Copy Markdown
Contributor Author

@HennerM @hpawe01 what is needed to get this merged?

@hpawe01

hpawe01 commented Oct 11, 2020

Copy link
Copy Markdown
Contributor

@HennerM @hpawe01 what is needed to get this merged?

I don't have merge permissions, so I guess you meant only @HennerM?

@HennerM
HennerM merged commit ead645a into ghidoz:master Oct 12, 2020
@HennerM

HennerM commented Oct 12, 2020

Copy link
Copy Markdown
Collaborator

I am afraid I can't maintain this repo anymore. It would be best if you could talk to @ghidoz about transfering ownership.

@fsaris

fsaris commented Oct 12, 2020

Copy link
Copy Markdown
Collaborator

@HennerM tnx for merging

@fsaris

fsaris commented Oct 12, 2020

Copy link
Copy Markdown
Collaborator

I am afraid I can't maintain this repo anymore. It would be best if you could talk to @ghidoz about transfering ownership.

Please let me know if you need someone to help here

@ghidoz

ghidoz commented Feb 19, 2021

Copy link
Copy Markdown
Owner

I am afraid I can't maintain this repo anymore. It would be best if you could talk to @ghidoz about transfering ownership.

Please let me know if you need someone to help here

@fsaris sorry, I missed the mention. Are you still interested in managing the project? I can add you as a collaborator

@fsaris

fsaris commented Feb 23, 2021

Copy link
Copy Markdown
Collaborator

@fsaris sorry, I missed the mention. Are you still interested in managing the project? I can add you as a collaborator

Sounds good 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants