Repository navigation
fit-params: accept --spec-type, -md, -ngld arguments - #30427
Open
claudiubelu wants to merge 2 commits into
Open
claudiubelu wants to merge 2 commits into
claudiubelu wants to merge 2 commits into
Conversation
Assisted-by: Claude Opus 5.5
`llama-server` accepts the `--spec-type`, `-md`, `-ngld` parameters and fits the draft / MTP context with the target, but `llama-fit-params` does not. Anything that estimates a server config with `llama-fit-params` will get a wrong estimate. `llama-fit-params` now accepts the same flags, improving the estimates. Assisted-by: Claude Opus 5.5
claudiubelu
requested review from
a team,
JohannesGaessler and
ggerganov
as code owners
October 12, 2026 22:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
llama-serveraccepts the--spec-type,-md,-ngldparameters and fits the draft / MTP context with the target, butllama-fit-paramsdoes not. Anything that estimates a server config withllama-fit-paramswill get a wrong estimate.llama-fit-paramsnow accepts the same flags, improving the estimates.Additional information
Fixes: #30424
Repro:
Requirements