Skip to content

ref(typing): Let feature and search helpers take a service account - #129423

Draft
gricha wants to merge 1 commit into
ref/sa-narrow-api-bfrom
ref/sa-narrow-widen
Draft

gricha wants to merge 1 commit into
ref/sa-narrow-api-bfrom
ref/sa-narrow-widen

Conversation

@gricha

@gricha gricha commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

is_provider_enabled, the preprod quota checks, investigation action kinds' cannot_apply_reasons, parse_user_value and store_issue_last_defaults now take a RequestPrincipal. They only forward the caller to features.has(), ignore it, or already check has_user(), so this is type-only.

Without it, #129402's mypy check would flag 4 more files.

@gricha
gricha added this pull request to stack #129364 October 31, 2026 02:27
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 31, 2026
@gricha
gricha removed this pull request from stack #129364 November 1, 2026 04:24
@gricha
gricha force-pushed the ref/sa-narrow-widen branch from 8e185f5 to 94da59d Compare November 1, 2026 04:24
@gricha
gricha added this pull request to stack #129440 November 1, 2026 04:24
@sentry

sentry Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Sentry Snapshot Testing

Name Added Removed Changed Renamed Unchanged Skipped Status
sentry-frontend
sentry-frontend
0 0 0 0 780 0 ✅ Unchanged

⚙️ sentry-frontend Snapshot Settings

is_provider_enabled, the preprod quota checks, investigation action kinds' cannot_apply_reasons, parse_user_value and store_issue_last_defaults now take a RequestPrincipal. They only forward the caller to features.has(), ignore it, or already check has_user(), so this is type-only.
@gricha
gricha force-pushed the ref/sa-narrow-widen branch from 94da59d to 70e65f0 Compare November 1, 2026 04:57

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant