Repository navigation
Conversation
TanStack Start splits route files into virtual modules such as `index.tsx?tss-serverfn-split`. The uploaded source maps kept these queries and paths relative to the map's directory, so frames did not show the path of the source file. Remove the split queries and make source paths relative to the project root, so frames show paths such as `src/routes/index.tsx`. A user's `sourcemaps.rewriteSources` still takes precedence.
…bled The default `filesToDeleteAfterUpload: ['./**/*.map']` does not enter dot directories like `.output`, so source maps that Sentry enabled stayed in the client build of Nitro apps. Delete the source maps in the output directory of each environment that only has source maps because Sentry enabled them. Keep source maps that the user enabled with `build.sourcemap`, an environment setting or `build.rolldownOptions.output.sourcemap`. Warn on Vite 7, where Sentry only knows `build.outDir`.
Server errors in TanStack Start stayed minified. Sentry did not turn on Nitro's source maps, and Nitro's maps stopped at its intermediate SSR bundle in `node_modules/.nitro`. Load the SSR source maps into Nitro's build, so the final maps point to `src/`. Turn on 'hidden' Nitro source maps only if no Vite or Nitro config sets them, and always set `sourcemapMinify: false` to keep `sourcesContent`. Delete the Nitro source maps that Sentry turned on after the upload. Fixes #21012 Co-Authored-By: kyrylolvov <kyrylolvov@icloud.com>
s1gr1d
force-pushed
the
sig/tanstack-start-source-maps
branch
from
October 14, 2026 11:55
a0e6667 to
a58eeb9
Compare
s1gr1d
changed the base branch from
develop
to
sig/tanstack-start-delete-source-maps
October 14, 2026 11:56
s1gr1d
marked this pull request as ready for review
October 14, 2026 11:58
s1gr1d
requested review from
chargome and
mydea
and removed request for
a team
October 14, 2026 11:58
Credit @kyrylolvov for #24356, which this fix is based on.
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 38a674a. Configure here.
…layers Sentry reads Nitro's config sources from the internal `_c12` option. Link the issue that asks Nitro to expose them, so the code can move to the public option later.
…-delete-source-maps # Conflicts: # packages/tanstackstart-react/src/vite/sourceMaps.ts
…k-start-source-maps
s1gr1d
added this pull request to stack #25439
October 16, 2026 08:29
In debug mode, log that no source maps are deleted after the upload when Sentry did not enable source map generation for the build. Before, debug mode logged nothing in this case.
…k-start-source-maps
Base automatically changed from
sig/tanstack-start-delete-source-maps
to
develop
October 16, 2026 12:13
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server errors in TanStack Start stayed minified: Nitro's source maps were off, or stopped at its intermediate SSR bundle in
node_modules/.nitro.src/.'hidden'Nitro source maps only if no config sets them, and always keepssourcesContent(sourcemapMinify: false).Nuxt 5 has the same Nitro issues: #25325 fixes
sourcesContent, and the map composition can be reused there.Based on #24356 by @kyrylolvov. Stacked on #25362.
Fixes #21012