Skip to content

perf: counting discarded telemetry for client reports no longer allocates #5687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ric-oliv merged 1 commit into from
Oct 8, 2026
Merged

perf: counting discarded telemetry for client reports no longer allocates #5687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Sentry/Internal/ThreadsafeCounterDictionary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@ private class CounterItem
/// </summary>
/// <param name="key">The key of the counter to increment.</param>
/// <param name="quantity">The amount to add to the counter.</param>
public void Add(TKey key, int quantity) => _items.GetOrAdd(key, new CounterItem()).Add(quantity);
public void Add(TKey key, int quantity) => _items.GetOrAdd(key, static _ => new CounterItem()).Add(quantity);

/// <summary>
/// Atomically increments a counter based on the key provided, creating the counter if necessary.
/// </summary>
/// <param name="key">The key of the counter to increment.</param>
public void Increment(TKey key) => _items.GetOrAdd(key, new CounterItem()).Increment();
public void Increment(TKey key) => _items.GetOrAdd(key, static _ => new CounterItem()).Increment();

/// <summary>
/// Gets a single counter's value while atomically resetting it to zero.
Expand Down
19 changes: 19 additions & 0 deletions test/Sentry.Tests/Internals/ThreadsafeCounterDictionaryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,4 +275,23 @@ void ReadAndAddToGrandTotal()
const int expectedGrandTotal = numCounters * numThreadsPerCounter * numIterationsPerThread;
Assert.Equal(expectedGrandTotal, grandTotal);
}

#if NET5_0_OR_GREATER && !__MOBILE__
[Fact]
public void AddAndIncrement_ExistingCounter_DoNotAllocate()
{
var key = DiscardReason.CallbackError.WithCategory(DataCategory.LogItem);
var counters = new ThreadsafeCounterDictionary<DiscardReasonWithCategory>();
counters.Add(key, 1);
counters.Increment(key);

var before = GC.GetAllocatedBytesForCurrentThread();
counters.Add(key, 1);
counters.Increment(key);
var allocated = GC.GetAllocatedBytesForCurrentThread() - before;

Assert.Equal(0, allocated);
Assert.Equal(4, counters[key]);
}
#endif
}
Loading