Repository navigation
fix: TraceIgnoreStatusCodes no longer drops outgoing HTTP requests traced with OpenTelemetry - #5643
Merged
Conversation
…aced with OpenTelemetry With OpenTelemetry, an HttpClient call with no local parent becomes an http.client transaction carrying http.response.status_code, so the processor dropped it. The spec scopes the option to incoming requests, so only filter http.server transactions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5643 +/- ##
==========================================
+ Coverage 74.37% 74.93% +0.56%
==========================================
Files 501 515 +14
Lines 18566 18973 +407
Branches 3603 3693 +90
==========================================
+ Hits 13808 14217 +409
+ Misses 3883 3876 -7
- Partials 875 880 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jamescrosswell
deleted the
fix/trace-ignore-status-codes-server-only
branch
September 30, 2026 21:27
3 tasks
This was referenced Oct 1, 2026
Closed
Closed
This was referenced Oct 2, 2026
This was referenced Oct 19, 2026
jonty-uk-gov-mirror
pushed a commit
to uk-gov-mirror/DFE-Digital.teaching-record-system
that referenced
this pull request
Oct 23, 2026
Updated [Sentry.AspNetCore](https://github.com/getsentry/sentry-dotnet) from 6.11.1 to 6.12.0. <details> <summary>Release notes</summary> _Sourced from [Sentry.AspNetCore's releases](https://github.com/getsentry/sentry-dotnet/releases)._ ## 6.12.0 ### Features ✨ - feat(otel): mark span processor based OpenTelemetry setup methods as obsolete by @jamescrosswell in [#5586](getsentry/sentry-dotnet#5586) ### Fixes 🐛 - fix(blazor): logging options set in UseSentry now take effect by @ric-oliv in [#5640](getsentry/sentry-dotnet#5640) - fix(log4net): send event properties as log attributes on log4net 3.x by @jamescrosswell in [#5559](getsentry/sentry-dotnet#5559) - fix: TraceIgnoreStatusCodes no longer drops outgoing HTTP requests traced with OpenTelemetry by @jamescrosswell in [#5643](getsentry/sentry-dotnet#5643) - fix: an exception in BeforeSend or BeforeSendTransaction now drops the item instead of sending it by @jamescrosswell in [#5610](getsentry/sentry-dotnet#5610) - fix: telemetry dropped by user callbacks and by validation is now counted in client reports by @jamescrosswell in [#5607](getsentry/sentry-dotnet#5607) - fix: exceptions thrown from BeforeBreadcrumb, log filters and BeforeScreenshotCapture no longer reach the application by @jamescrosswell in [#5606](getsentry/sentry-dotnet#5606) - fix: transaction processors no longer discard each other's results by @jamescrosswell in [#5621](getsentry/sentry-dotnet#5621) - fix: Throw ArgumentException for empty traceId in DynamicSamplingContext by @chiliec in [#5599](getsentry/sentry-dotnet#5599) ### Dependencies ⬆️ #### Deps - chore(deps): update Cocoa SDK to v9.30.0 by @github-actions in [#5656](getsentry/sentry-dotnet#5656) - chore(deps): update Cocoa SDK to v9.29.2 by @github-actions in [#5624](getsentry/sentry-dotnet#5624) - chore(deps): update Java SDK to v8.58.0 by @github-actions in [#5622](getsentry/sentry-dotnet#5622) - chore(deps): update Native SDK to v0.17.1 by @github-actions in [#5625](getsentry/sentry-dotnet#5625) - chore(deps): update Native SDK to v0.17.0 by @github-actions in [#5614](getsentry/sentry-dotnet#5614) ### Other - meta: remove duplicate Blank Issue template by @SatvikMishra08 in [#5601](getsentry/sentry-dotnet#5601) Commits viewable in [compare view](getsentry/sentry-dotnet@6.11.1...6.12.0). </details> Updated [Sentry.Extensions.Logging](https://github.com/getsentry/sentry-dotnet) from 6.11.1 to 6.12.0. <details> <summary>Release notes</summary> _Sourced from [Sentry.Extensions.Logging's releases](https://github.com/getsentry/sentry-dotnet/releases)._ ## 6.12.0 ### Features ✨ - feat(otel): mark span processor based OpenTelemetry setup methods as obsolete by @jamescrosswell in [#5586](getsentry/sentry-dotnet#5586) ### Fixes 🐛 - fix(blazor): logging options set in UseSentry now take effect by @ric-oliv in [#5640](getsentry/sentry-dotnet#5640) - fix(log4net): send event properties as log attributes on log4net 3.x by @jamescrosswell in [#5559](getsentry/sentry-dotnet#5559) - fix: TraceIgnoreStatusCodes no longer drops outgoing HTTP requests traced with OpenTelemetry by @jamescrosswell in [#5643](getsentry/sentry-dotnet#5643) - fix: an exception in BeforeSend or BeforeSendTransaction now drops the item instead of sending it by @jamescrosswell in [#5610](getsentry/sentry-dotnet#5610) - fix: telemetry dropped by user callbacks and by validation is now counted in client reports by @jamescrosswell in [#5607](getsentry/sentry-dotnet#5607) - fix: exceptions thrown from BeforeBreadcrumb, log filters and BeforeScreenshotCapture no longer reach the application by @jamescrosswell in [#5606](getsentry/sentry-dotnet#5606) - fix: transaction processors no longer discard each other's results by @jamescrosswell in [#5621](getsentry/sentry-dotnet#5621) - fix: Throw ArgumentException for empty traceId in DynamicSamplingContext by @chiliec in [#5599](getsentry/sentry-dotnet#5599) ### Dependencies ⬆️ #### Deps - chore(deps): update Cocoa SDK to v9.30.0 by @github-actions in [#5656](getsentry/sentry-dotnet#5656) - chore(deps): update Cocoa SDK to v9.29.2 by @github-actions in [#5624](getsentry/sentry-dotnet#5624) - chore(deps): update Java SDK to v8.58.0 by @github-actions in [#5622](getsentry/sentry-dotnet#5622) - chore(deps): update Native SDK to v0.17.1 by @github-actions in [#5625](getsentry/sentry-dotnet#5625) - chore(deps): update Native SDK to v0.17.0 by @github-actions in [#5614](getsentry/sentry-dotnet#5614) ### Other - meta: remove duplicate Blank Issue template by @SatvikMishra08 in [#5601](getsentry/sentry-dotnet#5601) Commits viewable in [compare view](getsentry/sentry-dotnet@6.11.1...6.12.0). </details> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TraceIgnoreStatusCodesnow only filtershttp.servertransactions. Until now it also dropped outgoingHttpClientcalls traced with OpenTelemetry.With OpenTelemetry, an
HttpClientcall that has no local parent (in aBackgroundService, a timer, startup code, or a consumer continuing a remotetraceparent) becomes anhttp.clienttransaction of its own.SentrySpanProcessor.OnEndcopieshttp.response.status_codeonto it, andTraceIgnoreStatusCodeTransactionProcessorthen dropped it whenever the downstream status matched the list. For example, a 401 or 403 from a downstream API usually means expired credentials, and that transaction silently disappeared.The spec says the option "applies exclusively to incoming requests". All of the SDK's incoming-request transactions use the
http.serveroperation: the ASP.NET CoreSentryTracingMiddleware, ASP.NET'sHttpContextExtensions, andSentrySpanProcessor.ParseOtelSpanDescriptionfor non-client HTTP spans. So the processor now checks the operation, as an allowlist rather than excludinghttp.client, so that other root transactions carrying a status code are left alone too.Found by @ric-oliv while reviewing #5632, which turns on a non-empty default for
TraceIgnoreStatusCodesin 7.0. That would expose this bug to every ASP.NET Core app using OpenTelemetry, so this fix needs to reachversion7before #5632 merges.Notes for review
TraceIgnoreStatusCodesthemselves, since the list is empty by default onmain.ParseOtelSpanDescription_HttpServeralongside the existinghttp.clienttest, since the processor now depends on OpenTelemetry server spans being mapped tohttp.server.🤖 Generated with Claude Code