Skip to content

Build Variables Source Generator - #4101

Merged
aritchie merged 38 commits into
mainfrom
2927-aot_buildvars_sourcegen
May 7, 2025
Merged

aritchie merged 38 commits into
mainfrom
2927-aot_buildvars_sourcegen

Conversation

@aritchie

@aritchie aritchie commented Apr 10, 2025 •

Copy link
Copy Markdown
Contributor

Resolves #2927

This is the initial implementation of proposed AOT build checks

Features

  • Generates a precompiled list of msbuild properties we were interested in based on various issues within our repo
  • Currently, we only look at PublishTrimmed and PublishAot in our AotHelper
  • Generates module initializer only on runnable targets
  • Ability to disable source generator if user encounters issue

TODO

  • Unit Tests
  • Document ability to disable source generator

@aritchie
aritchie marked this pull request as ready for review April 25, 2025 15:08
@aritchie

Copy link
Copy Markdown
Contributor Author

Before we release this, I would like to do a beta test to ensure all of the nuget stuff has zero issues. CC: @jamescrosswell

Comment thread modules/sentry-native Resolved
Comment thread src/Sentry/Sentry.csproj Resolved
Comment thread src/Sentry/SentrySdk.cs Resolved
Comment thread test/Sentry.Tests/Sentry.Tests.csproj Resolved

@bruno-garcia bruno-garcia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of stuff new to me so I don't have much to add, just a few suggestions

Comment thread CHANGELOG.md Resolved
Comment thread src/Sentry/Sentry.csproj Resolved
Comment thread src/Sentry/Sentry.csproj Resolved
Comment thread src/Sentry/SentrySdk.cs Resolved
Comment thread test/Sentry.Tests/Sentry.Tests.csproj Resolved
aritchie and others added 2 commits April 30, 2025 09:28
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate AotHelper properties at compile time

5 participants