Skip to content

docs: Indicate which bool return value of AddLogEntryFilter actually excludes a message #5296

Closed

Description

@kanadaj

Description

See in title; right now the XML docs don't actually tell you that "true" excludes the value. We do have this indicated for IExceptionFilter but not for AddLogEntryFilter's lambdas

Activity

  1. added
    .NETPull requests that update .net code
    on Jun 18, 2026
  2. moved this to Waiting for: Product Owner in GitHub Issues with 👀 3on Jun 18, 2026
  3. linear-code commented on Jun 18, 2026

    @linear-code
  4. changed the title [-]docs: Indicate which bool return value of AddLogEntryFilter actually excludes a message[/-] [+]docs: Indicate which `bool` return value of `AddLogEntryFilter` actually excludes a message[/+] on Jun 18, 2026
  5. self-assigned this
    on Jun 18, 2026
  6. Flash0ver commented on Jun 18, 2026

    @Flash0ver
    Contributor

    Well spotted, @kanadaj ... thanks for reporting this missing documentation comment.
    Is this what you had in mind?

  7. kanadaj commented on Jun 18, 2026

    @kanadaj
    ContributorAuthor

    @Flash0ver I'd probably use the wording "filtered out" for clarity instead of just "filtered"

  8. moved this from Waiting for: Product Owner to No status in GitHub Issues with 👀 3on Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions