Skip to content

🚑️ Fix compilation with rustc v1.80 - #180

Merged
a-kenji merged 1 commit into
mainfrom
fix/type-inference
Aug 11, 2024
Merged

a-kenji merged 1 commit into
mainfrom
fix/type-inference

Conversation

@a-kenji

@a-kenji a-kenji commented Aug 10, 2024

Copy link
Copy Markdown
Collaborator

rustc --version: v1.80.0 has a type inference regression. This causes compilation of centerpiece to fail, because we use an affected version of the time crate.

This updates the time crate to a released version with a fix.

Reference:

`rustc --version`: `v1.80.0` has a type inference regression.
This causes compilation of `centerpiece` to fail, because we use an
affected version of the `time` crate.

This updates the time crate to a released version with a fix.

Reference:
- NixOS/nixpkgs#332957
- rust-lang/rust#125319
- rust-lang/rust#99969

@friedow friedow left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-kenji
a-kenji merged commit 05e6640 into main Aug 11, 2024
@a-kenji
a-kenji deleted the fix/type-inference branch August 11, 2024 11:17
@a-kenji

a-kenji commented Aug 11, 2024

Copy link
Copy Markdown
Collaborator Author

Maybe we can tag a release in the next 1-2 weeks so that nixpkgs can pick it up?

@friedow

friedow commented Aug 11, 2024

Copy link
Copy Markdown
Owner

I'll release centerpiece right now ;)

This branch was previously deployed

1 inactive deployment
cachix — 6b7a0c14 Deployed Aug 10, 2024 by a-kenji
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants