Repository navigation
Conversation
Unknown keys inside [rpc_endpoints] and [etherscan] entries were dropped without a warning, because WarningsProvider takes allowed keys from the default config, where both sections are empty. Check each entry against the keys its deserializer accepts and report UnknownSectionKey with the entry in the section name, e.g. `etherscan.mainnet`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
aelmanaa
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse and
stevencartavia
as code owners
October 31, 2026 07:51
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #17978.
Unknown keys inside
[rpc_endpoints]and[etherscan]entries are dropped without a warning, unlike everywhere else infoundry.toml. For examplechainId = 1in an[etherscan]entry, as in aave-v3-origin, or a misspelledretries.Solution
WarningsProviderchecks the keys of each entry in these two sections, whether they are at the top level or in a profile, against the keys their deserializers accept:endpoint,url,endpoints,retries,retry_backoff,compute_units_per_second,auth;key,url,chain.An unknown key gives the existing
UnknownSectionKeywarning, with the entry in the section name (etherscan.mainnet). Plain-URL RPC entries are not tables and are skipped. Configs that still setapi_versionin an explorer entry, which forge no longer reads, now get a warning as well.PR Checklist
🤖 Generated with Claude Code