Repository navigation
refactor(review): align cop badges with Important, Nit, and Pre-existing - #34
Merged
Merged
Conversation
The five-color ladder and APPROVE-WITH-CHANGES disagreed with the review tags. One badge per tag, category labels stay, and only Important or an AGENTS.md hard rule blocks. Co-authored-by: Florian <fmflurry@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cop and comment-judge badges now match the review tags from #28. One badge per tag: 🔴 Important, 🟡 Nit, ⚪ Pre-existing, and ❓ for a question. Category labels (
[bug],[sec],[arch],[risk],[nit],[comment],[format]) stay as text after the tag. Verdicts are APPROVE or BLOCK. Any Important finding, or any finding that cites an AGENTS.md hard rule, is BLOCK. Otherwise APPROVE. Questions never block. Pre-existing does not block. APPROVE-WITH-CHANGES is gone.The comment-judge JSON
tierisImportant(false/stale),Nit(forbidden, narration, noise), or❓(unsure). The reviewer still emits a forbidden comment as 🔴 Important [comment], and a false/stale comment blocks only after the reviewer quotes a contradicting line. Plugin version is 0.4.5.Applied to Claude Code (
.claude/agents,.claude/skills), OpenCode (prompts/agents,skills,opencode.jsonc), and the rebuilt Cursor plugin. Always-loaded rules stay at 7. GDPR, database-health, and/planrisk levels were not changed.Before / after
tierImportantNit❓Left unchanged
No unrelated status-dot uses of 🟠, 🟢, or 🔵 were in the repo. The only remaining mention of APPROVE-WITH-CHANGES is the 0.4.5 changelog line that records its removal. GDPR, database health, and
/planrisk scales were not edited.Risk
Reviewers stop emitting APPROVE-WITH-CHANGES. A Nit no longer blocks by itself. DDD pattern items that used the old green "fix before merge" marker are now Nit and block only when the finding cites an AGENTS.md hard rule. Cop BLOCK rules, security findings, and confirmed false or forbidden comments still block. You would notice a review that used to say APPROVE-WITH-CHANGES now say APPROVE, with the same items listed as Nit.
How to revert
Revert commit
1ce3b23onrefactor/cop-tag-badges. That restores the five-color ladder, APPROVE-WITH-CHANGES, and plugin 0.4.4.Tier
T2. The diff is wide but mechanical, and it changes which review findings block a merge. No secrets, auth, or data paths.